gh-111788: Don't treat path in robots.txt as URL in urllib.robotparser
#113231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on when parse weird robot.txt
|
Can you update the PR title to more accurately (and succinctly) describe the change? |
aisk
changed the title
|
Thanks for the review, updated! |
aisk
changed the title
urllib.robotparser
There was a problem hiding this comment.
Nice PR, but the path can already be spoiled by applying unquote() which can decode %3F in the path to false ?. Fixing this requires larger changes. See #138502 which fixes several issues including this.
|
Fixed as a part of #138502. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.