gh-113471: adds custom default content-type to http.server #113475

jcomeauictx · 2023-12-25T19:07:19Z

Issue: default http content-type #113471

ghost · 2023-12-25T19:07:21Z

All commit authors signed the Contributor License Agreement.

bedevere-app · 2023-12-25T19:07:22Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

…pupgrade

serhiy-storchaka

This change need tests.

I am not sure how much useful is this feature. It only allows to override the MIME type of unrecognized types. And would not it be simpler to configure your browser?

Lib/http/server.py

Misc/NEWS.d/next/Library/2023-12-25-19-14-07.gh-issue-113471.ZQMpbI.rst

…QMpbI.rst Co-authored-by: Serhiy Storchaka <[email protected]>

…pupgrade

encukou

The feature looks useful to me; I've wanted it once or twice before. However, adding it would be a lot work. Not sure if it's worth your time.

The change needs documentation (in Doc/library/http.server.rst, both for the attribute and CLI option).

Lib/http/server.py

donBarbos · 2025-03-08T02:14:16Z

@jcomeauictx are you going to continue working on this PR?

jcomeauictx · 2025-03-08T02:45:01Z

@jcomeauictx are you going to continue working on this PR?

I've forgotten what else needs to be done. And in any case, nobody else seems interested in it.

donBarbos · 2025-03-08T02:49:52Z

Doc/library/http.server.rst

+
+        python -m http.server --default-content-type text/html
+
+.. versionchanged:: 3.13


Suggested change

.. versionchanged:: 3.13

.. versionchanged:: next

donBarbos · 2025-03-08T02:53:54Z

I've forgotten what else needs to be done. And in any case, nobody else seems interested in it.

I'm interested :)
I think if you add tests you can ping someone from core members

jcomeauictx · 2025-03-08T03:00:21Z

OK, I'll look into it tomorrow. No idea where to add them, though, or what precisely needs to be tested.

donBarbos · 2025-03-08T03:13:13Z

we have at least two test classes where default_request_version attribute are redefined (file test_httpservers.py lines 93 and 321) and then checked, I think we need to do the same with our new attribute

jcomeauictx · 2025-03-08T13:58:51Z

I've looked at test_httpservers.py but really don't know how to go about it. Would you be willing to write the tests?

donBarbos · 2025-03-08T14:20:11Z

I've looked at test_httpservers.py but really don't know how to go about it. Would you be willing to write the tests?

yea, thank you. I will try to send suggestion as soon as possible.
but if you send it yourself earlier I won't be against :-)

donBarbos · 2025-03-09T02:48:24Z

@jcomeauictx could you merge main branch for correct tests?

jcomeauictx · 2025-03-09T07:03:20Z

done, I think? also changed versionchanged to next as per your suggestion above.

donBarbos · 2025-03-16T10:46:44Z

@jcomeauictx could you merge main branch again and update your new option description? (because we updated CLI documentation style)

donBarbos · 2025-03-16T10:46:53Z

cc @picnixz what do you think about this feature?

picnixz

I won't comment of the usefulness as I don't think I'll ever use it but the feature seems easy to implement so I'll accept the work. However, we need:

tests
a What's New entry (in Doc/whatsnew/3.14.rst; locate the http.server section in Improved Modules, or create one if none exists and carefully write it in the same style as other sections do)

Doc/library/http.server.rst

Lib/http/server.py

Misc/NEWS.d/next/Library/2023-12-25-19-14-07.gh-issue-113471.ZQMpbI.rst

Co-authored-by: Bénédikt Tran <[email protected]>

…QMpbI.rst Co-authored-by: Bénédikt Tran <[email protected]>

Co-authored-by: Bénédikt Tran <[email protected]>

Doc/library/http.server.rst

Co-authored-by: donBarbos <[email protected]>

jcomeauictx · 2025-03-16T13:06:53Z

donBarbos, I just added it, but isn't the indentation wrong?

jcomeauictx · 2025-03-16T14:10:43Z

"move the description of this flag to the right place", what does that mean? Could you please do it? I just corrected the hyphenation.

…

On Sun, Mar 16, 2025 at 6:10 AM donBarbos ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Doc/library/http.server.rst <#113475 (comment)>: > +By default, the server uses the MIME type ``'application/octet-stream'`` for +the ``Content-Type`` header when the content type cannot be guessed from the +URL's extension (if any). The option ``--default-content-type`` overrides +this default with one of the user's choosing:: + + python -m http.server --default-content-type text/html + +.. versionchanged:: next + Added the ``--default-content-type`` option. @jcomeauictx <https://github.com/jcomeauictx> we added usage of .. option:: directory for CLI flags, we also need to move the description of this flag to the right place, could you move it? (I also forgot the second - before default-content-type, please add it :) — Reply to this email directly, view it on GitHub <#113475 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABRUXUAWLKM3YQ2WNDDTZL2UVZ5XAVCNFSM6AAAAABYSPI2O6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMOBYGY3DSNJZGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- John Comeau KE5TFZ WSEE965 ***@***.***> ***@***.***> http://jc.unternet.net/ "A place for everything, and everything all over the place"

donBarbos · 2025-03-16T14:58:40Z

Sorry I can't. I mean move on to the rest options

jcomeauictx · 2025-03-16T15:08:42Z

OK, please check that I did it right.

…

On Sun, Mar 16, 2025 at 7:59 AM donBarbos ***@***.***> wrote: Sorry I can't. I mean move on to the rest options — Reply to this email directly, view it on GitHub <#113475 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABRUXV7CQROXHJA4WOQ2N32UWGTPAVCNFSM6AAAAABYSPI2O6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRXGQ4DKNRZHE> . You are receiving this because you were mentioned.Message ID: ***@***.***> [image: donBarbos]*donBarbos* left a comment (python/cpython#113475) <#113475 (comment)> Sorry I can't. I mean move on to the rest options — Reply to this email directly, view it on GitHub <#113475 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABRUXV7CQROXHJA4WOQ2N32UWGTPAVCNFSM6AAAAABYSPI2O6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRXGQ4DKNRZHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- John Comeau KE5TFZ WSEE965 ***@***.***> ***@***.***> http://jc.unternet.net/ "A place for everything, and everything all over the place"

jcomeauictx added 4 commits December 25, 2023 14:57

changeable default

7848730

ready to test

19cde54

passed test this time

e7860c3

DRY fix for python#113471

b945ced

bedevere-app bot added the awaiting review label Dec 25, 2023

bedevere-app bot mentioned this pull request Dec 25, 2023

default http content-type #113471

Open

blurb-it bot and others added 6 commits December 25, 2023 19:14

📜🤖 Added by blurb_it.

c2da505

Merge branch 'main' into httpupgrade

2f900fe

Merge branch 'main' into httpupgrade

3486458

Merge branch 'httpupgrade' of github.com:jcomeauictx/cpython into htt…

497f11e

…pupgrade

Merge branch 'main' into httpupgrade

48cdd20

Merge branch 'main' into httpupgrade

d189051

serhiy-storchaka reviewed Jan 26, 2024

View reviewed changes

Lib/http/server.py Outdated Show resolved Hide resolved

Lib/http/server.py Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Library/2023-12-25-19-14-07.gh-issue-113471.ZQMpbI.rst Outdated Show resolved Hide resolved

jcomeauictx and others added 6 commits January 27, 2024 04:40

Update Misc/NEWS.d/next/Library/2023-12-25-19-14-07.gh-issue-113471.Z…

4a6370b

…QMpbI.rst Co-authored-by: Serhiy Storchaka <[email protected]>

Merge branch 'httpupgrade' of github.com:jcomeauictx/cpython into htt…

f7ff834

…pupgrade

removed short option and inefficiency pointed out by @serhiy-storchaka

7ae00ea

Merge branch 'main' into httpupgrade

b9841d0

adding tests per @serhiy_storchaka's suggestion, not all pass yet

2ba2aee

tests all pass

819491f

encukou reviewed Feb 2, 2024

View reviewed changes

Lib/http/server.py Outdated Show resolved Hide resolved

Lib/http/server.py Outdated Show resolved Hide resolved

addresses some of @encukou's observations. still need to add tests.

2defce3

encukou added awaiting changes and removed awaiting review labels Apr 15, 2024

donBarbos reviewed Mar 8, 2025

View reviewed changes

donBarbos mentioned this pull request Mar 9, 2025

gh-113471: adds custom default content-type to http.server #131000

Closed

jcomeauictx added 2 commits March 8, 2025 23:40

Merge branch 'main' into httpupgrade for donBarbos

43e6851

donBarbos's suggestion

69800b9

picnixz requested changes Mar 16, 2025

View reviewed changes

jcomeauictx and others added 7 commits March 16, 2025 04:54

Merge branch 'main' into httpupgrade

339b3ee

Update Doc/library/http.server.rst

4778206

Co-authored-by: Bénédikt Tran <[email protected]>

Update Misc/NEWS.d/next/Library/2023-12-25-19-14-07.gh-issue-113471.Z…

8903147

…QMpbI.rst Co-authored-by: Bénédikt Tran <[email protected]>

Update Lib/http/server.py

dfa30d9

Co-authored-by: Bénédikt Tran <[email protected]>

Update Lib/http/server.py

3b8450d

Co-authored-by: Bénédikt Tran <[email protected]>

Update Doc/library/http.server.rst

59f152a

Co-authored-by: Bénédikt Tran <[email protected]>

Update Lib/http/server.py

259e9b5

Co-authored-by: Bénédikt Tran <[email protected]>

donBarbos reviewed Mar 16, 2025

View reviewed changes

Doc/library/http.server.rst Outdated Show resolved Hide resolved

Update Doc/library/http.server.rst

1662667

Co-authored-by: donBarbos <[email protected]>

corrected double hyphen

6fa0a6d

moved to options section

afe8ebb


		python -m http.server --default-content-type text/html

		.. versionchanged:: 3.13

Uh oh!

gh-113471: adds custom default content-type to http.server #113475

Are you sure you want to change the base?

gh-113471: adds custom default content-type to http.server #113475

Uh oh!

Conversation

jcomeauictx commented Dec 25, 2023 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Dec 25, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-app bot commented Dec 25, 2023

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

encukou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

donBarbos commented Mar 8, 2025

Uh oh!

jcomeauictx commented Mar 8, 2025

Uh oh!

donBarbos Mar 8, 2025

Choose a reason for hiding this comment

Uh oh!

donBarbos commented Mar 8, 2025

Uh oh!

jcomeauictx commented Mar 8, 2025

Uh oh!

donBarbos commented Mar 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jcomeauictx commented Mar 8, 2025

Uh oh!

donBarbos commented Mar 8, 2025

Uh oh!

donBarbos commented Mar 9, 2025

Uh oh!

jcomeauictx commented Mar 9, 2025

Uh oh!

donBarbos commented Mar 16, 2025

Uh oh!

donBarbos commented Mar 16, 2025

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jcomeauictx commented Mar 16, 2025

Uh oh!

jcomeauictx commented Mar 16, 2025 via email

Uh oh!

donBarbos commented Mar 16, 2025

Uh oh!

jcomeauictx commented Mar 16, 2025 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jcomeauictx commented Dec 25, 2023 •

edited by bedevere-app bot

Loading

ghost commented Dec 25, 2023 •

edited by ghost

Loading

donBarbos commented Mar 8, 2025 •

edited

Loading