Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/http/cookies.py
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ def OutputString(self, attrs=None):
( # Optional group: there may not be a value.
\s*=\s* # Equal Sign
(?P<val> # Start of group 'val'
"(?:[^\\"]|\\.)*" # Any double-quoted string
"(?:\\"|.)*?" # Any double-quoted string
| # or
# Special case for "expires" attr
(\w{3,6}day|\w{3}),\s # Day of the week or abbreviated day
Expand Down
23 changes: 23 additions & 0 deletions Lib/test/test_http_cookies.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,29 @@ def test_basic(self):
'Set-Cookie: d=r',
'Set-Cookie: f=h'
))
},

# gh-92936: allow double quote in cookie values
{
'data': 'cookie="{"key": "value"}"',
'dict': {'cookie': '{"key": "value"}'},
'repr': "<SimpleCookie: cookie='{\"key\": \"value\"}'>",
'output': 'Set-Cookie: cookie="{"key": "value"}"',
},
{
'data': 'key="some value; surrounded by quotes"',
'dict': {'key': 'some value; surrounded by quotes'},
'repr': "<SimpleCookie: key='some value; surrounded by quotes'>",
'output': 'Set-Cookie: key="some value; surrounded by quotes"',
},
{
'data': 'session="user123"; preferences="{"theme": "dark"}"',
'dict': {'session': 'user123', 'preferences': '{"theme": "dark"}'},
'repr': "<SimpleCookie: preferences='{\"theme\": \"dark\"}' session='user123'>",
'output': '\n'.join((
'Set-Cookie: preferences="{"theme": "dark"}"',
'Set-Cookie: session="user123"',
))
}
]

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Update regex used by ``http.cookies.SimpleCookie`` to handle values containing
double quotes.
Loading