-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
gh-115231: fill __module__ for built-in staticmethods #115232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
skirpichev
wants to merge
15
commits into
python:main
Choose a base branch
from
skirpichev:static-bltin-__module__-115231
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+24
−1
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9b31877
gh-115231: fill __module__ attribute for built-in staticmethods
skirpichev be1c7ef
PyObject_GetAttr -> PyObject_GetOptionalAttr
skirpichev 1f854ee
Merge branch 'main' into static-bltin-__module__-115231
skirpichev c4dec10
fill __module__ attribute for built-in classmethods too
skirpichev 1e25d84
use PyObject_GetAttr & ignore exceptions
skirpichev 63b05a0
Merge branch 'master' into static-bltin-__module__-115231
skirpichev 777bc8d
address review: use type_module()
skirpichev d1650bf
+ rename news
skirpichev d0f5bb0
Merge branch 'main' into static-bltin-__module__-115231
skirpichev e20339b
XXX Revert "address review: use type_module()"
skirpichev 4ba1288
Merge branch 'main' into static-bltin-__module__-115231
skirpichev 543a5b3
Address review: use type_module()
skirpichev b3fbb8c
Merge branch 'master' into static-bltin-__module__-115231
skirpichev 6666a1a
Revert "fill __module__ attribute for built-in classmethods too"
skirpichev 386f383
+1
skirpichev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Core_and_Builtins/2024-02-10-05-42-26.gh-issue-115231.6T7dzi.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Setup ``__module__`` attribute for built-in static methods. Patch by Sergey | ||
B Kirpichev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.