gh-115892: Fix ntpath.splitext() with UNC paths #115996
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os.path.splitext() on Windows no longer splits an "extension" from the server or share name in the UNC path.
|
As I posted on the issue, I don't particularly want splitext to depend on the start of the string (or on the entire string, if you want to view it that way). If the caller is splitext-ing something that isn't a path to a file, they'll get invalid results (e.g. if it's a directory). I don't think it's worth changing from an implementation that only considers the end of the string. (I post this half to remind myself next time I come and look at the PR, because I nearly just hit "merge" before remembering what this was about 😆 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.path.splitext() on Windows no longer splits an "extension" from the server or share name in the UNC path.
os.path.splitext()can split UNC drive on Windows #115892