Skip to content

Do not call retain on Objective-C string literals #116258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not call retain on Objective-C string literals #116258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Mac/PythonLauncher/FileSettings.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ - (id)initForFSDefaultFileType: (NSString *)filetype
dict = [factorySettings objectForKey: filetype];
if (dict == NULL) {
NSLog(@"factorySettings.plist misses file type \"%@\"", filetype);
interpreter = [@"no default found" retain];
interpreter = @"no default found";
return NULL;
}
[self applyValuesFromDict: dict];
Expand All @@ -134,7 +134,7 @@ - (id)initForFSDefaultFileType: (NSString *)filetype
}
}
if (interpreter == NULL)
interpreter = [@"no default found" retain];
interpreter = @"no default found";
origsource = NULL;
return self;
}
Expand All @@ -159,7 +159,7 @@ - (id)initForDefaultFileType: (NSString *)filetype
self = [self initWithFileSettings: fsdefaults];
if (!self) return self;
interpreters = [fsdefaults->interpreters retain];
scriptargs = [@"" retain];
scriptargs = @"";
[self applyUserDefaults: filetype];
prefskey = [filetype retain];
return self;
Expand Down
4 changes: 2 additions & 2 deletions Mac/PythonLauncher/MyDocument.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ - (id)init

// Add your subclass-specific initialization here.
// If an error occurs here, send a [self dealloc] message and return nil.
script = [@"<no script>.py" retain];
filetype = [@"Python Script" retain];
script = @"<no script>.py";
filetype = @"Python Script";
settings = NULL;
}
return self;
Expand Down
Loading