Skip to content

Use NSInteger/NSUInteger where appropiate #116273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −11
Open

Use NSInteger/NSUInteger where appropiate #116273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Mac/PythonLauncher/FileSettings.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ - (id)initForFileType: (NSString *)filetype

- (id)initForFSDefaultFileType: (NSString *)filetype
{
int i;
NSUInteger i;
NSString *filename;
NSDictionary *dict;
static NSDictionary *factorySettings;
Expand Down
2 changes: 1 addition & 1 deletion Mac/PythonLauncher/MyAppDelegate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ - (void)testFileTypeBinding
NSURL *appUrl;
static NSString *extensions[] = { @"py", @"pyw", @"pyc", NULL};
NSString **ext_p;
int i;
NSInteger i;

if ([[NSUserDefaults standardUserDefaults] boolForKey: @"SkipFileBindingTest"])
return;
Expand Down
8 changes: 4 additions & 4 deletions Mac/PythonLauncher/PreferencesWindowController.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@

- (void)controlTextDidChange:(NSNotification *)aNotification;

- (unsigned int)comboBox:(NSComboBox *)aComboBox indexOfItemWithStringValue:(NSString *)aString;
- (id)comboBox:(NSComboBox *)aComboBox objectValueForItemAtIndex:(int)index;
- (int)numberOfItemsInComboBox:(NSComboBox *)aComboBox;

- (NSUInteger)comboBox:(NSComboBox *)aComboBox
indexOfItemWithStringValue:(NSString *)aString;
- (id)comboBox:(NSComboBox *)aComboBox objectValueForItemAtIndex:(NSInteger)index;
- (NSUInteger)numberOfItemsInComboBox:(NSComboBox *)aComboBox;

@end
10 changes: 5 additions & 5 deletions Mac/PythonLauncher/PreferencesWindowController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,24 +93,24 @@ - (void)controlTextDidChange:(NSNotification *)aNotification
};

// NSComboBoxDataSource protocol
- (unsigned int)comboBox:(NSComboBox *)aComboBox indexOfItemWithStringValue:(NSString *)aString
- (NSUInteger)comboBox:(NSComboBox *)aComboBox indexOfItemWithStringValue:(NSString *)aString
{
NSArray *interp_list = [settings interpreters];
unsigned int rv = [interp_list indexOfObjectIdenticalTo: aString];
NSUInteger rv = [interp_list indexOfObjectIdenticalTo: aString];
return rv;
}

- (id)comboBox:(NSComboBox *)aComboBox objectValueForItemAtIndex:(int)index
- (id)comboBox:(NSComboBox *)aComboBox objectValueForItemAtIndex:(NSInteger)index
{
NSArray *interp_list = [settings interpreters];
id rv = [interp_list objectAtIndex: index];
return rv;
}

- (int)numberOfItemsInComboBox:(NSComboBox *)aComboBox
- (NSUInteger)numberOfItemsInComboBox:(NSComboBox *)aComboBox
{
NSArray *interp_list = [settings interpreters];
int rv = [interp_list count];
NSUInteger rv = [interp_list count];
return rv;
}

Expand Down
Loading