Skip to content

Conversation

@SalehDehqanpour
Copy link
Contributor

@SalehDehqanpour SalehDehqanpour commented Mar 19, 2024

The code does not differentiate between text and binary files so the sentence should be removed from the doc. See #117026


📚 Documentation preview 📚: https://cpython-previews--117027.org.readthedocs.build/

…xt files

The code does not differentiate between text and binary files so the sentence should be removed from the doc. See python#117026
@ghost
Copy link

ghost commented Mar 19, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Contributor

@davidlowryduda davidlowryduda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good. But something that confuses me is that it looks like the line of code in server.py has never changed, so it's not like this something that changed from python2 to python3.

This feels like Chesterson's fence.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Thank you for your contribution @SalehDehqanpour.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 16, 2025
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) May 16, 2025 19:08
@serhiy-storchaka serhiy-storchaka merged commit ea2d707 into python:main May 16, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs May 16, 2025
@miss-islington-app
Copy link

Thanks @SalehDehqanpour for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 16, 2025
… docs (pythonGH-117027)

The code was changed in 0f7cddc (bpo-839496/pythongh-39531).
(cherry picked from commit ea2d707)

Co-authored-by: Saleh Dehqanpour <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 16, 2025
… docs (pythonGH-117027)

The code was changed in 0f7cddc (bpo-839496/pythongh-39531).
(cherry picked from commit ea2d707)

Co-authored-by: Saleh Dehqanpour <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 16, 2025

GH-134107 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 16, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 16, 2025

GH-134108 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 16, 2025
serhiy-storchaka pushed a commit that referenced this pull request May 16, 2025
…r docs (GH-117027) (GH-134107)

The code was changed in 0f7cddc (bpo-839496/gh-39531).
(cherry picked from commit ea2d707)

Co-authored-by: Saleh Dehqanpour <[email protected]>
serhiy-storchaka pushed a commit that referenced this pull request May 16, 2025
…r docs (GH-117027) (GH-134108)

The code was changed in 0f7cddc (bpo-839496/gh-39531).
(cherry picked from commit ea2d707)

Co-authored-by: Saleh Dehqanpour <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants