- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.3k
          GH-73991: Add pathlib.Path.copy()
          #119058
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 11 commits
      Commits
    
    
            Show all changes
          
          
            19 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      7128a7a
              
                GH-73991: Add `pathlib.Path.copy()` method.
              
              
                barneygale 4cf63e6
              
                Fix tests, add news
              
              
                barneygale e83f53e
              
                Comment on use of `shutil.copy2()`
              
              
                barneygale 092a0e0
              
                Use fcopyfile() / sendfile() where available.
              
              
                barneygale ac37fa5
              
                Merge branch 'main' into gh-73991-copy
              
              
                barneygale a9a216e
              
                Drop usage of shutil
              
              
                barneygale cbf6174
              
                Fix tests, add FICLONE support
              
              
                barneygale 738f8ed
              
                Move to `pathlib._os`.
              
              
                barneygale 83cb4dc
              
                Move a bit more code into _os.
              
              
                barneygale 0aceea2
              
                Handle classes that subclass PathBase and os.PathLike but not Path.
              
              
                barneygale eec9e7f
              
                Reword
              
              
                barneygale fddcd73
              
                Add test for directory symlinks
              
              
                barneygale c683c2d
              
                Fix handling of symlinks to directories on Windows.
              
              
                barneygale 0be714f
              
                Expose _winapi.COPY_FILE_DIRECTORY
              
              
                barneygale 5169b9a
              
                Test copying empty file.
              
              
                barneygale 7c9c893
              
                Apply suggestions from code review
              
              
                barneygale 0e1e4f1
              
                Drop `follow_symlinks` argument for now.
              
              
                barneygale 8434924
              
                Merge branch 'main' into gh-73991-copy
              
              
                barneygale d8cb6c6
              
                Merge branch 'main' into gh-73991-copy
              
              
                barneygale File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,124 @@ | ||
| """ | ||
| Low-level OS functionality wrappers used by pathlib. | ||
| """ | ||
|  | ||
| from errno import EBADF, EOPNOTSUPP, ETXTBSY, EXDEV | ||
| import os | ||
| import sys | ||
| try: | ||
| import fcntl | ||
| except ImportError: | ||
| fcntl = None | ||
| try: | ||
| import posix | ||
| except ImportError: | ||
| posix = None | ||
|  | ||
|  | ||
| def get_copy_blocksize(infd): | ||
| """Determine blocksize for fastcopying on Linux. | ||
| Hopefully the whole file will be copied in a single call. | ||
| The copying itself should be performed in a loop 'till EOF is | ||
| reached (0 return) so a blocksize smaller or bigger than the actual | ||
| file size should not make any difference, also in case the file | ||
| content changes while being copied. | ||
| """ | ||
| try: | ||
| blocksize = max(os.fstat(infd).st_size, 2 ** 23) # min 8 MiB | ||
| except OSError: | ||
| blocksize = 2 ** 27 # 128 MiB | ||
| # On 32-bit architectures truncate to 1 GiB to avoid OverflowError, | ||
| # see gh-82500. | ||
| if sys.maxsize < 2 ** 32: | ||
| blocksize = min(blocksize, 2 ** 30) | ||
| return blocksize | ||
|  | ||
|  | ||
| if fcntl and hasattr(fcntl, 'FICLONE'): | ||
| def clonefd(source_fd, target_fd): | ||
| """ | ||
| Perform a lightweight copy of two files, where the data blocks are | ||
| copied only when modified. This is known as Copy on Write (CoW), | ||
| instantaneous copy or reflink. | ||
| """ | ||
| fcntl.ioctl(target_fd, fcntl.FICLONE, source_fd) | ||
| else: | ||
| clonefd = None | ||
|  | ||
|  | ||
| if posix and hasattr(posix, '_fcopyfile'): | ||
| def copyfd(source_fd, target_fd): | ||
| """ | ||
| Copy a regular file content using high-performance fcopyfile(3) | ||
| syscall (macOS). | ||
| """ | ||
| posix._fcopyfile(source_fd, target_fd, posix._COPYFILE_DATA) | ||
| elif hasattr(os, 'copy_file_range'): | ||
| def copyfd(source_fd, target_fd): | ||
| """ | ||
| Copy data from one regular mmap-like fd to another by using a | ||
| high-performance copy_file_range(2) syscall that gives filesystems | ||
| an opportunity to implement the use of reflinks or server-side | ||
| copy. | ||
| This should work on Linux >= 4.5 only. | ||
| """ | ||
| blocksize = get_copy_blocksize(source_fd) | ||
| offset = 0 | ||
| while True: | ||
| sent = os.copy_file_range(source_fd, target_fd, blocksize, | ||
| offset_dst=offset) | ||
| if sent == 0: | ||
| break # EOF | ||
| offset += sent | ||
| elif hasattr(os, 'sendfile'): | ||
| def copyfd(source_fd, target_fd): | ||
| """Copy data from one regular mmap-like fd to another by using | ||
| high-performance sendfile(2) syscall. | ||
| This should work on Linux >= 2.6.33 only. | ||
| """ | ||
| blocksize = get_copy_blocksize(source_fd) | ||
| offset = 0 | ||
| while True: | ||
| sent = os.sendfile(target_fd, source_fd, offset, blocksize) | ||
| if sent == 0: | ||
| break # EOF | ||
| offset += sent | ||
| else: | ||
| copyfd = None | ||
|  | ||
|  | ||
| def copyfileobj(source_f, target_f): | ||
| """ | ||
| Copy data from file-like object source_f to file-like object target_f. | ||
| """ | ||
| try: | ||
| source_fd = source_f.fileno() | ||
| target_fd = target_f.fileno() | ||
| except Exception: | ||
| pass # Fall through to generic code. | ||
| else: | ||
| try: | ||
| # Use OS copy-on-write where available. | ||
| if clonefd: | ||
| try: | ||
| clonefd(source_fd, target_fd) | ||
| return | ||
| except OSError as err: | ||
| if err.errno not in (EBADF, EOPNOTSUPP, ETXTBSY, EXDEV): | ||
| raise err | ||
|  | ||
| # Use OS copy where available. | ||
| if copyfd: | ||
| copyfd(source_fd, target_fd) | ||
| return | ||
| except OSError as err: | ||
| # Produce more useful error messages. | ||
| err.filename = source_f.name | ||
| err.filename2 = target_f.name | ||
| raise err | ||
|  | ||
| # Last resort: copy with fileobj read() and write(). | ||
| read_source = source_f.read | ||
| write_target = target_f.write | ||
| while buf := read_source(1024 * 1024): | ||
| write_target(buf) | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
          
            2 changes: 2 additions & 0 deletions
          
          2 
        
  Misc/NEWS.d/next/Library/2024-05-15-01-36-08.gh-issue-73991.CGknDf.rst
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Add :meth:`pathlib.Path.copy`, which copies the content of one file to another, | ||
| like :func:`shutil.copyfile`. | 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.