Skip to content

gh-120384: Fix array-out-of-bounds crash in list_ass_subscript #120442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 6 commits into from
Jun 21, 2024
Merged

gh-120384: Fix array-out-of-bounds crash in list_ass_subscript #120442

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
87cc89f
gh-120384: Fix array-out-of-bounds crash in `list_ass_subscript`
sobolevn Jun 13, 2024
73ac63c
Add more tests
sobolevn Jun 13, 2024
df77cb5
Fix reflick
sobolevn Jun 13, 2024
738662e
Move test to `list_tests`
sobolevn Jun 13, 2024
1b6e061
Move test to `list_tests`
sobolevn Jun 13, 2024
d10c4e5
Address review
sobolevn Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Lib/test/list_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,14 @@ def test_setslice(self):

self.assertRaises(TypeError, a.__setitem__)

def test_slice_assign_iterator(self):
x = self.type2test(range(5))
x[0:3] = iter(self.type2test(reversed(range(3))))
self.assertEqual(x, self.type2test([2, 1, 0, 3, 4]))

x[:] = iter(self.type2test(reversed(range(3))))
self.assertEqual(x, self.type2test([2, 1, 0]))

def test_delslice(self):
a = self.type2test([0, 1])
del a[1:2]
Expand Down
3 changes: 2 additions & 1 deletion Objects/listobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3711,8 +3711,9 @@ list_ass_subscript(PyObject* _self, PyObject* item, PyObject* value)
step);

if (step == 1) {
int res = list_ass_slice(self, start, stop, seq);
Py_DECREF(seq);
return list_ass_slice(self, start, stop, value);
return res;
}

if (PySequence_Fast_GET_SIZE(seq) != slicelength) {
Expand Down