Skip to content

gh-121045: Use link test to check whether -fstack-protector-strong works #121258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

gh-121045: Use link test to check whether -fstack-protector-strong works #121258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2df6c92
pythongh-121045: Disable -fstack-protector-strong for gcc compiler in…
ayappanec Jul 2, 2024
b157e09
Merge branch 'main' into gh-121045
ayappanec Jul 22, 2024
89fa135
pythongh-121045: Use link test to check -fstack-protector-strong flag
ayappanec Jul 22, 2024
7f1e440
Merge branch 'main' into gh-121045
ayappanec Jul 23, 2024
ea1b825
Regenerate configure file
ayappanec Jul 23, 2024
a267445
Merge branch 'main' into gh-121045
ayappanec Jul 26, 2024
0a6b097
Merge branch 'main' into gh-121045
ayappanec Aug 1, 2024
fe9e133
Regenerate configure file
ayappanec Aug 1, 2024
28ff299
Merge branch 'main' into gh-121045
ayappanec Aug 23, 2024
1041065
Merge branch 'main' into gh-121045
ayappanec Aug 30, 2024
543893e
Merge branch 'main' into gh-121045
ayappanec Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 22 additions & 14 deletions configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 18 additions & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2496,6 +2496,20 @@ AC_DEFUN([PY_CHECK_CC_WARNING], [
AS_VAR_POPDEF([py_var])
])

dnl PY_CHECK_CC_CFLAG(ENABLE, CFLAG, [MSG])
AC_DEFUN([PY_CHECK_CC_CFLAG], [
AS_VAR_PUSHDEF([py_var], [ac_cv_$1_]m4_normalize($2)[_flag])
AC_CACHE_CHECK([m4_ifblank([$3], [if we can $1 $CC $2 flag], [$3])], [py_var], [
AS_VAR_COPY([py_cflags], [CFLAGS])
AS_VAR_APPEND([CFLAGS], [" -f$2 -Werror"])
AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[]])],
[AS_VAR_SET([py_var], [yes])],
[AS_VAR_SET([py_var], [no])])
AS_VAR_COPY([CFLAGS], [py_cflags])
])
AS_VAR_POPDEF([py_var])
])

# tweak BASECFLAGS based on compiler and platform
AS_VAR_IF([with_strict_overflow], [yes],
[BASECFLAGS="$BASECFLAGS $STRICT_OVERFLOW_CFLAGS"],
Expand All @@ -2512,7 +2526,10 @@ AC_MSG_RESULT([$enable_safety])

if test "$enable_safety" = "yes"
then
AX_CHECK_COMPILE_FLAG([-fstack-protector-strong], [CFLAGS_NODIST="$CFLAGS_NODIST -fstack-protector-strong"], [AC_MSG_WARN([-fstack-protector-strong not supported])], [-Werror])
PY_CHECK_CC_CFLAG([enable], [stack-protector-strong], [if we can add -fstack-protector-strong])
AS_VAR_IF([ac_cv_enable_stack_protector_strong_flag], [yes],
[CFLAGS_NODIST="$CFLAGS_NODIST -fstack-protector-strong"], AC_MSG_WARN([-fstack-protector-strong not supported]))

AX_CHECK_COMPILE_FLAG([-Wtrampolines], [CFLAGS_NODIST="$CFLAGS_NODIST -Wtrampolines"], [AC_MSG_WARN([-Wtrampolines not supported])], [-Werror])
AX_CHECK_COMPILE_FLAG([-Wconversion], [CFLAGS_NODIST="$CFLAGS_NODIST -Wconversion"], [AC_MSG_WARN([-Wconversion not supported])], [-Werror])
AX_CHECK_COMPILE_FLAG([-Wimplicit-fallthrough], [CFLAGS_NODIST="$CFLAGS_NODIST -Wimplicit-fallthrough"], [AC_MSG_WARN([-Wimplicit-fallthrough not supported])], [-Werror])
Expand Down
Loading