Skip to content

gh-111051: [tests] Wait a second to support filesystems with low-resolution mtime #121959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2024
Merged

gh-111051: [tests] Wait a second to support filesystems with low-resolution mtime #121959

merged 2 commits into from
Jul 22, 2024

Conversation

@ambv
Copy link
Contributor

@ambv ambv commented Jul 18, 2024 •
edited by bedevere-app bot
Loading

@ambv ambv requested a review from gaogaotiantian as a code owner July 18, 2024 11:12
@bedevere-app bedevere-app bot mentioned this pull request Jul 18, 2024
Closed
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Jul 18, 2024
@ambv ambv added skip news needs backport to 3.13 bugs and security fixes labels Jul 18, 2024
@ambv
Copy link
Contributor Author

ambv commented Jul 18, 2024

I fail to see how the TSAN failures could be related.

@ZeroIntensity
Copy link
Member

See #121946, it's unrelated

@gaogaotiantian
Copy link
Member

If the resolution is 1s, is waiting for 1s enough?

@serhiy-storchaka
Copy link
Member

See also #121620.

@ambv ambv merged commit cad11a2 into python:main Jul 22, 2024
@miss-islington-app
Copy link

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2024
@ambv @miss-islington
pythongh-111051: [tests] Wait a second to support filesystems with lo…
af0ad6e 
…w-resolution mtime (pythonGH-121959)

(cherry picked from commit cad11a2)

Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 22, 2024

GH-122114 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 22, 2024
serhiy-storchaka pushed a commit that referenced this pull request Aug 12, 2024
@miss-islington @ambv
[3.13] gh-111051: [tests] Wait a second to support filesystems with l…
8b64ce4 
…ow-resolution mtime (GH-121959) (GH-122114)

(cherry picked from commit cad11a2)

Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaogaotiantian gaogaotiantian Awaiting requested review from gaogaotiantian gaogaotiantian is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ambv @ZeroIntensity @gaogaotiantian @serhiy-storchaka