Skip to content

Conversation

@tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Jul 18, 2024

Only touches the tests, so no news entry needed?

@hugovk
Copy link
Member

hugovk commented Oct 2, 2024

@Eclips4 You can now merge this, if you like!

Perhaps update from main first.

@Eclips4
Copy link
Member

Eclips4 commented Oct 2, 2024

@Eclips4 You can now merge this, if you like!

Perhaps update from main first.

I would like to get Serhiy's opinion on this firstly :)

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Eclips4 Eclips4 merged commit 656b7a3 into python:main Oct 3, 2024
34 checks passed
@Eclips4 Eclips4 added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 3, 2024
@miss-islington-app
Copy link

Thanks @tomasr8 for the PR, and @Eclips4 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @tomasr8 for the PR, and @Eclips4 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2024
…stant. (pythonGH-121983)

Test invalid quoting constant

(cherry picked from commit 656b7a3)

Co-authored-by: Tomas R <[email protected]>
Co-authored-by: Kirill Podoprigora <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2024
…stant. (pythonGH-121983)

Test invalid quoting constant

(cherry picked from commit 656b7a3)

Co-authored-by: Tomas R <[email protected]>
Co-authored-by: Kirill Podoprigora <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 3, 2024

GH-124925 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 3, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 3, 2024

GH-124926 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 3, 2024
Eclips4 added a commit that referenced this pull request Oct 3, 2024
…nstant. (GH-121983) (#124925)

gh-121982: ``csv``: Add a test case for invalid ``quoting`` constant. (GH-121983)

Test invalid quoting constant

(cherry picked from commit 656b7a3)

Co-authored-by: Tomas R <[email protected]>
Co-authored-by: Kirill Podoprigora <[email protected]>
@tomasr8 tomasr8 deleted the csv-test-coverage branch October 3, 2024 08:36
Yhg1s pushed a commit that referenced this pull request Oct 3, 2024
…nstant. (GH-121983) (#124926)

gh-121982: ``csv``: Add a test case for invalid ``quoting`` constant. (GH-121983)

Test invalid quoting constant

(cherry picked from commit 656b7a3)

Co-authored-by: Tomas R <[email protected]>
Co-authored-by: Kirill Podoprigora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants