Skip to content

gh-122081: fixed crash in decimal.IEEEContext() #122082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 19, 2024
Merged

gh-122081: fixed crash in decimal.IEEEContext() #122082

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c77e56
gh-122081: fixed crash in decimal.IEEEContext()
skirpichev Jul 21, 2024
1b1df41
Apply suggestions from code review
skirpichev Aug 18, 2024
0211303
Update Misc/NEWS.d/next/Library/2024-07-21-10-45-24.gh-issue-122081.d…
kumaraditya303 Aug 19, 2024
3ff2973
Apply suggestions from code review
kumaraditya303 Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2024-07-21-10-45-24.gh-issue-122081.dNrYMq.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix a crash in the :func:`!decimal.IEEEContext` optional function
available via the ``EXTRA_FUNCTIONALITY`` configuration flag.
4 changes: 2 additions & 2 deletions Modules/_decimal/_decimal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1519,7 +1519,7 @@ init_extended_context(PyObject *v)
#ifdef EXTRA_FUNCTIONALITY
/* Factory function for creating IEEE interchange format contexts */
static PyObject *
ieee_context(PyObject *dummy UNUSED, PyObject *v)
ieee_context(PyObject *self, PyObject *v)
{
PyObject *context;
mpd_ssize_t bits;
Expand All @@ -1536,7 +1536,7 @@ ieee_context(PyObject *dummy UNUSED, PyObject *v)
goto error;
}

decimal_state *state = get_module_state_by_def(Py_TYPE(v));
decimal_state *state = get_module_state(self);
context = PyObject_CallObject((PyObject *)state->PyDecContext_Type, NULL);
if (context == NULL) {
return NULL;
Expand Down