Skip to content

GH-122123: add devel field to sys.version_info #122125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

GH-122123: add devel field to sys.version_info #122125

wants to merge 2 commits into from

Conversation

@FFY00
Copy link
Member

@FFY00 FFY00 commented Jul 22, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 22, 2024
Open
@FFY00 FFY00 changed the title GH-122123: add devel field to sys.version GH-122123: add devel field to sys.version_info Jul 22, 2024
@FFY00 FFY00 marked this pull request as ready for review September 20, 2024 06:28
@FFY00 FFY00 added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed awaiting core review labels Sep 20, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @FFY00 for commit f1c1a77 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 20, 2024
@FFY00
Copy link
Member Author

FFY00 commented Sep 20, 2024

@zooba what changes need to be made for the Windows build?

erlend-aasland
erlend-aasland reviewed Sep 20, 2024
View reviewed changes
Python/sysmodule.c
version_info__doc__, /* doc */
version_info_fields, /* fields */
5
5 /* n_in_sequence */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 6, no?

@vstinner vstinner mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FFY00 @bedevere-bot @erlend-aasland