-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-122071: Fixed traceback leaks global code when file does not exist #122126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lhish
wants to merge
21
commits into
python:main
Choose a base branch
from
lhish:fix-issue-122071
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f1e1189
Fixed traceback leaks global code when exec
lhish f510454
📜🤖 Added by blurb_it.
blurb-it[bot] dcc5718
Merge branch 'main' into fix-issue-122071
lhish b40bc28
adapt for zipimporter
lhish a9f8458
Fixed missing file's lazycache
lhish 0fab629
Update trace_back test
lhish f3a3f97
Merge branch 'main' into fix-issue-122071
lhish 9d7594a
Merge branch 'main' into fix-issue-122071
lhish c28b698
Merge branch 'main' into fix-issue-122071
lhish 17e3545
Merge branch 'main' into fix-issue-122071
lhish 44715f2
Update the method to check the existence of the file
lhish 1940da7
Merge branch 'main' into fix-issue-122071
lhish 78d1a14
change description
lhish 363758a
Apply suggestions from code review
lhish fa2d76b
Revert "Update trace_back test"
lhish 7f7308a
change the implementation of get_lines
lhish 250f026
make restriction stronger
lhish b2407ff
Merge branch 'main' into fix-issue-122071
lhish e3796bb
Apply suggestions from code review
lhish 3005636
change return value from true to false
lhish 787ea13
change tests to make it correct
lhish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Core and Builtins/2024-07-22-13-58-16.gh-issue-122071.c5EQZL.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fixed traceback leaks global code when exec. | ||
lhish marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.