-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
gh-121608: Add supporting perf trampoline on -linux-musl #122370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@pablogsal I think that there is no harm in adding support for musl. |
I am a bit hessitant because we don't have CI for this. Have we tried it at least in a musl container or system and check that works? |
pablogsal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but see my comment
I will share the result of cross-check from my side before merging this. |
|
@pablogsal See my verification script. :) mainDockerfileOutputPRDockerfileOutput |
|
We still have: so this is still not testing the |
Yeah.. Thanks for catching this. let me check. |
|
!buildbot Alpine |
|
!buildbot Alpine |
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit b8573ea 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Uh oh!
There was an error while loading. Please reload this page.