Skip to content
Closed
5 changes: 2 additions & 3 deletions Doc/library/fractions.rst
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,11 @@ another rational number, or from a string.

.. attribute:: numerator

Numerator of the Fraction in lowest term.
Numerator of the Fraction in lowest terms.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Numerator of the Fraction in lowest terms.
Numerator of the Fraction, expressed in its lowest terms.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, we say that "The Fraction class inherits from the abstract base class numbers.Rational, and implements all of the methods and operations from that class."

So, we could move these numerator/denominator descriptions to the Rational class.

CC @AA-Turner

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be worse; it requires people to look in two places to find out what happens with Fraction. Happy to improve in both places, but we shouldn't remove from here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr continued in #136800. I hope, I'll address review quickly;-)

but we shouldn't remove from here.

I'm not sure if it worth verbosity. I don't see e.g. where described real/imag properties for builtin types, except for the numbers module.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skirpichev should this PR (#122464) be closed?

A

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. I tried to attribute this work in a follow-up pr.


.. attribute:: denominator

Denominator of the Fraction in lowest term.

Denominator of the Fraction in lowest terms and positive.

.. method:: as_integer_ratio()

Expand Down
2 changes: 2 additions & 0 deletions Lib/fractions.py
Original file line number Diff line number Diff line change
Expand Up @@ -413,10 +413,12 @@ def limit_denominator(self, max_denominator=1000000):

@property
def numerator(a):
"""Numerator in lowest terms."""
return a._numerator

@property
def denominator(a):
"""Denominator in lowest terms and positive."""
return a._denominator

def __repr__(self):
Expand Down