gh-122431: Disallow negative values in readline.append_history_file
#122469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
changed the title
readline.append_history_file. readline.append_history_file
Really, this is just a commit to retrigger CI.
|
I'm quite confused on how the documentation tests could be related. |
vstinner
reviewed
Dec 5, 2024
Co-authored-by: Victor Stinner <[email protected]>
vstinner
added
needs backport to 3.12
vstinner
approved these changes
Dec 5, 2024
|
Thanks @ZeroIntensity for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2024
…_file` (pythonGH-122469) (cherry picked from commit 208b0fb) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2024
…_file` (pythonGH-122469) (cherry picked from commit 208b0fb) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
|
GH-127641 is a backport of this pull request to the 3.13 branch. |
|
GH-127642 is a backport of this pull request to the 3.12 branch. |
vstinner
added a commit
that referenced
this pull request
Dec 5, 2024
…y_file` (GH-122469) (#127642) gh-122431: Disallow negative values in `readline.append_history_file` (GH-122469) (cherry picked from commit 208b0fb) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
vstinner
added a commit
that referenced
this pull request
Dec 5, 2024
…y_file` (GH-122469) (#127641) gh-122431: Disallow negative values in `readline.append_history_file` (GH-122469) (cherry picked from commit 208b0fb) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…_file` (python#122469) Co-authored-by: Victor Stinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FWIW, this is actually a bug upstream in GNU's
append_historyfunction, but this is the best that Python can do in the meantime to prevent accessing out of bounds memory.