-
-
Notifications
You must be signed in to change notification settings - Fork 33k
gh-123858: Improve Doc: SyntaxWarning is emitted during bytecode generation #122844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could someone please help review this PR? Thank you. |
iritkatriel
reviewed
Sep 12, 2024
Co-authored-by: Alyssa Coghlan <[email protected]>
ncoghlan
reviewed
Aug 28, 2025
Co-authored-by: Alyssa Coghlan <[email protected]>
0776052
to
9c00bc8
Compare
ncoghlan
approved these changes
Aug 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your patience with the review process!
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 29, 2025
…e generation (pythongh-122844) --------- (cherry picked from commit 5f79067) Co-authored-by: Hang <[email protected]> Co-authored-by: Alyssa Coghlan <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 29, 2025
…e generation (pythongh-122844) --------- (cherry picked from commit 5f79067) Co-authored-by: Hang <[email protected]> Co-authored-by: Alyssa Coghlan <[email protected]>
GH-138243 is a backport of this pull request to the 3.13 branch. |
GH-138244 is a backport of this pull request to the 3.14 branch. |
hugovk
pushed a commit
that referenced
this pull request
Aug 29, 2025
…de generation (gh-122844) (#138244) Co-authored-by: Hang <[email protected]> Co-authored-by: Alyssa Coghlan <[email protected]>
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…bytecode generation (pythongh-122844) (python#138244) Co-authored-by: Hang <[email protected]> Co-authored-by: Alyssa Coghlan <[email protected]>
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
…e generation (pythongh-122844) --------- Co-authored-by: Alyssa Coghlan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on eliminating the
SyntaxWarning
. It's strange that this error only shows up once. After some research, I found that:However, this isn't mentioned in the documentation. I noticed other warnings have descriptions like "ignored by default." Adding this information could help reduce confusion.
📚 Documentation preview 📚: https://cpython-previews--122844.org.readthedocs.build/