gh-122845: fix parameter_list_starargs in function definition pseudo-grammar #122847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to Artur Chakhvadze for bugfix.
bedevere-app
bot
added
docs
skirpichev
changed the title
|
CC @terryjreedy, involved in d.p.o thread. |
|
My involvement was that I misread the existing grammar ;-), and agreed that there seemed to be a problem, but I will not judge the proposed replacement. There are better people to do so. |
skirpichev
added
needs backport to 3.12
|
Maybe @pablogsal ? |
pablogsal
approved these changes
Jan 21, 2025
|
This is correct as allows the missing and disallows bare * |
|
Thanks @skirpichev for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 21, 2025
…seudo-grammar (pythonGH-122847) Thanks to Artur Chakhvadze for bugfix. (cherry picked from commit 6105846) Co-authored-by: Sergey B Kirpichev <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 21, 2025
…seudo-grammar (pythonGH-122847) Thanks to Artur Chakhvadze for bugfix. (cherry picked from commit 6105846) Co-authored-by: Sergey B Kirpichev <[email protected]>
|
GH-129150 is a backport of this pull request to the 3.13 branch. |
|
GH-129151 is a backport of this pull request to the 3.12 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Artur Chakhvadze for bugfix.
📚 Documentation preview 📚: https://cpython-previews--122847.org.readthedocs.build/