Skip to content

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Aug 9, 2024

Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could use some help from @python/proofreaders.

Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have made my previous comments into a single review.

@bedevere-app
Copy link

bedevere-app bot commented Aug 24, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@skirpichev
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-app bot commented Aug 24, 2024

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

@skirpichev skirpichev added 3.12 only security fixes 3.13 bugs and security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed 3.12 only security fixes 3.13 bugs and security fixes labels Sep 25, 2024
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A final nitpick on wording.

@skirpichev
Copy link
Contributor Author

CC @ericvsmith, are you waiting for the second opinion? (BTW, I'm ok above suggestion by @picnixz)

Co-authored-by: Bénédikt Tran <[email protected]>
@encukou encukou enabled auto-merge (squash) October 29, 2024 14:06
@encukou encukou merged commit 0bbbe15 into python:main Oct 29, 2024
25 checks passed
@miss-islington-app
Copy link

Thanks @skirpichev for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2024

GH-126128 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 29, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2024

GH-126129 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 29, 2024
@skirpichev skirpichev deleted the docs-complex-fmt-122767 branch October 29, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news