-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-119349: Add ctypes.util function to list loaded shared libraries #122946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following commit authors need to sign the Contributor License Agreement: |
|
I'm not a fan of returning |
Yes, what to do in the error case is certainly interesting. In my original implementation I returned We certainly could let the error propagate, but there isn't much you can do as a user with the exceptions. Most use cases I can imagine would catch the error and then return something falsey, either None or |
I think we should offload that choice to the user. |
|
It's a good way to show issues without flat-on taking down the (maybe
server) program.
Could you imagine that happening in GitHub's code storage server code?
Kai Griswold
…On Tue, Aug 13, 2024, 3:34 AM Peter Bierma ***@***.***> wrote:
I'm not a fan of returning None and emitting a warning instead of raising
an error. That seems like a potential footgun; I could see developers being
very confused as to why their code isn't working if they have warnings
suppressed, or simply don't see them (e.g. they're buried in logs).
—
Reply to this email directly, view it on GitHub
<#122946 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWUL3JYBIXZW4JVUOVEW4S3ZRHAIPAVCNFSM6AAAAABMMPSC6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBVGY3TGMRWHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
I am seeing that we're special-casing not having support for AIX. Does CPython even officially support AIX? |
|
It's not listed in PEP 11, but there are ~150 other mentions of the platform in the codebase, mostly in test code, like the mentions here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of emitting warnings. Either you silently skip the failed names, or you raise. Or you return bytes and you won't have decoding issues for instance. But if you can list the DLLs being loaded, you should always return the complete list, and if you can't, then you should return None (other functions seem to do it as well when they can't get the result for whatever reason).
Misc/NEWS.d/next/Library/2024-08-12-11-58-15.gh-issue-119349.-xTnHl.rst
Outdated
Show resolved
Hide resolved
|
I'm not sure how long it takes to be reviewed and for the bot to update, but I wanted to note that my employer has filled out the CLA at this point |
|
Bikeshedding: if we're going to allow returning |
The dllist() function calls platform-specific APIs in order to list the runtime libraries loaded by Python and any imported modules. If these fail for any reason, None is returned.
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 5ab1b02 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
On that platform, libc is called libc-2.28.so, not libc.so. Instead, the test searches for libffi.so, which is a dependency of ctypes
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 80be2ab 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
|
Android has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much LGTM, apart from my many nitpicks. Looking forward to seeing this merged!
Misc/NEWS.d/next/Library/2024-08-12-11-58-15.gh-issue-119349.-xTnHl.rst
Outdated
Show resolved
Hide resolved
Android links ctypes against libffi statically. We could change this, but if it's only for this test, then it would be easier to just test for libc on Android instead. |
This should cover all tested systems, including Andriod which statically links libffi
I went ahead and updated the test to check if either libc.so or libffi.so is in the return on unix-alikes. Hopefully this guards against more platform issues, and we can always add a third candidate to this list if we end up with an even weirder platform that has neither... |
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 1c3594e 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for doing this and for your patience with reviews, @WardBrian
The
dllist()function calls platform-specific APIs in order to list the runtime libraries loaded by Python and any imported modules. If these fail for any reason, None is returned.The name could surely be bikeshedded, at the moment it is taken from the Julia function of the same name
Previous discussions:
Code based on https://github.com/WardBrian/dllist by myself with a contribution from @eryksun
📚 Documentation preview 📚: https://cpython-previews--122946.org.readthedocs.build/