Fix timezone sanity check for platforms with unsigned time_t #123277
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
vstinner
reviewed
Sep 18, 2024
| julyzone_t = -get_gmtoff(t, &p); | ||
| julyname[9] = '\0'; | ||
|
|
||
| int janzone = (int)janzone_t; |
There was a problem hiding this comment.
You should add a comment explaining this cast: mention unsigned time_t, maybe QNX, and the issue number.
I would feel more comfortable with int64_t type instead of int.
StanFromIreland
added
the
pending
|
Please create an issue for this. |
|
@Osyotr didn't address my review for one year, I consider the PR as inactive and close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example of such platform is QNX, where
time_tis_Uint32_t.