-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
GH-123516: Improve JIT memory consumption by invalidating cold executors #123402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
savannahostrowski
wants to merge
61
commits into
python:main
from
savannahostrowski:jit-mem-invalidate-10
Closed
Changes from 19 commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
0eac77b
resolve conflict
savannahostrowski d576296
tests pass except ssl
savannahostrowski 68e95d6
remove file
savannahostrowski c903af4
this is broken
savannahostrowski 5ca6b7f
gc approach
savannahostrowski beb4f65
rebase
savannahostrowski 427dbf5
Update has_run to run_count
savannahostrowski 92d5590
update initialized run_count and move invalidate old
savannahostrowski 0cdf638
set threshold to 1`
savannahostrowski 58e7447
move incrementing run count into a new op
savannahostrowski 6c047e4
add invalidation threshold in gc of 10
savannahostrowski 2645023
move back to incremenet
savannahostrowski 7c7ae98
remove print
savannahostrowski 6d6d306
move invalidation to executor creation
savannahostrowski 4d086fe
change threshold
savannahostrowski d08e45a
new line
savannahostrowski 6315877
update constant
savannahostrowski 622c266
📜🤖 Added by blurb_it.
blurb-it[bot] e5117b2
Merge branch 'main' into jit-mem-invalidate-10
savannahostrowski 7c6704c
resolve conflict
savannahostrowski 1d72fdd
tests pass except ssl
savannahostrowski 1778185
remove file
savannahostrowski 2506821
this is broken
savannahostrowski fca6dec
gc approach
savannahostrowski 29436fd
rebase
savannahostrowski b969b11
Update has_run to run_count
savannahostrowski a669e0f
update initialized run_count and move invalidate old
savannahostrowski deb73ec
set threshold to 1`
savannahostrowski 9fa55e8
move incrementing run count into a new op
savannahostrowski e4a461a
add invalidation threshold in gc of 10
savannahostrowski d5a2bed
move back to incremenet
savannahostrowski d232e63
remove print
savannahostrowski e4a456a
move invalidation to executor creation
savannahostrowski b7d2d5a
change threshold
savannahostrowski 6dcd2dc
new line
savannahostrowski 219f890
update constant
savannahostrowski fb7b04d
📜🤖 Added by blurb_it.
blurb-it[bot] ea397a3
Merge branch 'jit-mem-invalidate-10' of https://github.com/savannahos…
savannahostrowski 310d20c
address pr comments
savannahostrowski d2f9dc4
refactor invalidatecold
savannahostrowski d755d56
refactor to was_run bool
savannahostrowski c9534c0
update blurb
savannahostrowski 61cd3c5
Merge branch 'main' into jit-mem-invalidate-10
savannahostrowski e5065ad
Update op name to be more reflective of was_run
savannahostrowski 2d09259
fix typo
savannahostrowski d2e8e29
rename uop
savannahostrowski a894598
dedent and initialize executors_created
savannahostrowski 758ee03
Merge branch 'main' into jit-mem-invalidate-10
savannahostrowski 1927bfe
address some PR comments
savannahostrowski 8ee0d7f
Update Python/optimizer.c
savannahostrowski cedd65d
Update Python/optimizer.c
savannahostrowski 0a9b5b6
make was_run uint`
savannahostrowski 180a68e
add comment for JIT_CLEANUP_THRESHOLD
savannahostrowski 7cb9cba
Remove extraneous reset of executors_created
savannahostrowski 8939ecf
Merge branch 'main' into jit-mem-invalidate-10
savannahostrowski 00f03d2
Merge branch 'main' into jit-mem-invalidate-10
savannahostrowski 4981ab2
Merge branch 'jit-mem-invalidate-10' of https://github.com/savannahos…
savannahostrowski 3c59316
condense conditional statements
savannahostrowski 306c3c3
Merge branch 'main' into jit-mem-invalidate-10
savannahostrowski fe50615
Address PR comments from Brandt and Mark
savannahostrowski d51817b
Merge branch 'main' into jit-mem-invalidate-10
savannahostrowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Core_and_Builtins/2024-08-27-21-44-14.gh-issue-116017.ZY3yBY.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Improved JIT memory consumption by invalidating cold executors | ||
savannahostrowski marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.