Fix override value in os.rst #123522
Open
Fix override value in os.rst #123522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
docs
| .. versionchanged:: 3.13 | ||
| If :option:`-X cpu_count <-X>` is given or :envvar:`PYTHON_CPU_COUNT` is set, | ||
| :func:`cpu_count` returns the overridden value *n*. | ||
| :func:`cpu_count` returns the override value *n*. |
There was a problem hiding this comment.
The language is weird either way, may be 'overriding value'
There was a problem hiding this comment.
Hi there. Shouldn't it be like "return value" used in these docs? (English is not my native language, so I could be mixing different things)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
python -X cpu_count=ncommand line, n value is not overridden by anything. It actually overrides the defaultos.cpu_count()'s return value. So the text should say "override value" instead of "overridden value".Please backport to 3.13
📚 Documentation preview 📚: https://cpython-previews--123522.org.readthedocs.build/