Skip to content

gh-122765: make prompt in activate.csh robust against unbalanced quotes and newlines #123751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 17, 2024
Merged

gh-122765: make prompt in activate.csh robust against unbalanced quotes and newlines #123751

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0cd09d2
gh-122765 make prompt in activate.csh robust against unbalanced quote…
JacekDuszenko Sep 5, 2024
2d48db8
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 6, 2024
942933c
Merge branch 'main' into main
JacekDuszenko Sep 6, 2024
ad6256f
remove :q when saving the old prompt for later retrieval
JacekDuszenko Sep 6, 2024
e483bd2
Merge branch 'main' into main
JacekDuszenko Sep 6, 2024
17a83bb
Merge branch 'main' into main
brettcannon Sep 16, 2024
65ae0c1
Merge branch 'main' into main
brettcannon Sep 16, 2024
7125e0b
Merge branch 'python:main' into main
JacekDuszenko Sep 17, 2024
7e157e3
Merge branch 'main' into main
brettcannon Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/venv/scripts/posix/activate.csh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ setenv PATH "$VIRTUAL_ENV/__VENV_BIN_NAME__:$PATH"
setenv VIRTUAL_ENV_PROMPT "__VENV_PROMPT__"


set _OLD_VIRTUAL_PROMPT="$prompt"
set _OLD_VIRTUAL_PROMPT="$prompt:q"

if (! "$?VIRTUAL_ENV_DISABLE_PROMPT") then
set prompt = "(__VENV_PROMPT__) $prompt"
set prompt = "(__VENV_PROMPT__) $prompt:q"
endif

alias pydoc python -m pydoc
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-09-06-00-00-43.gh-issue-122765.tx4hsr.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix unbalanced quote errors occurring when activate.csh in :mod:`venv` was sourced with a custom prompt containing unpaired quotes or newlines.
Loading