-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-123742: Fixed get_payload
not being able to parse headers with spaces
#123761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This comment was marked as duplicate.
This comment was marked as duplicate.
Misc/NEWS.d/next/Library/2024-09-06-11-58-17.gh-issue-123742.jSBNUv.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Library/2024-09-06-11-58-17.gh-issue-123742.jSBNUv.rst
Outdated
Show resolved
Hide resolved
get_payload
not being able to parse headers with spaces
This comment was marked as outdated.
This comment was marked as outdated.
@rruuaanng, I will point again to the devguide and suggest that you read it again. The Getting Started section states that we avoid force-pushing; it messes up the review process and does not play well with CI feedback. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Misc/NEWS.d/next/Library/2024-09-06-11-58-17.gh-issue-123742.jSBNUv.rst
Outdated
Show resolved
Hide resolved
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous review remarks were not addressed; please address them.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a test for this?
It has been a long time since this PR was opened. If there are no problems, I hope we can approve it :) |
I discussed this with Bénédikt in #123742 and got some feedback. I think we can follow the conclusion of practice, which is to remove trailing spaces, otherwise it will cause parsing errors, even though the RFC is vague about this, but I think making the module work properly is our ultimate pursuit. |
Thank you, Erlend, for your repeated review of this. But now, I will close this PR, It has been solved. |
After getting the email encoding format, added strip() to remove unexpected spaces