Skip to content

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Sep 12, 2024

AFAICT there is no point in calling codegen_annotations_in_scope when ste->ste_annotations_used is false. Am I wrong?

Fixes #124019.

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this seems right.

@iritkatriel iritkatriel merged commit 6e06e01 into python:main Sep 12, 2024
40 checks passed
@iritkatriel iritkatriel deleted the annot branch September 12, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

codegen_annotations_in_scope is called when ste->ste_annotations_used is false

2 participants