Skip to content

gh-124040: adjust few tests in testHypot/testDist to get exactly computed results #124042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 19, 2024
Merged

gh-124040: adjust few tests in testHypot/testDist to get exactly computed results #124042

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a4b73dd
gh-124040: simplify two hypot tests
skirpichev Sep 13, 2024
9fba2cb
Fix also dist test
skirpichev Sep 13, 2024
e1284da
address review: Use two-argument form with exact result to test hypot()
skirpichev Sep 13, 2024
ed5ccc9
address review: change hypot test for bool's to produce exact value
skirpichev Sep 13, 2024
b40e553
Merge branch 'main' into simplify-hypot-test-124040
skirpichev Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions Lib/test/test_math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,11 +809,13 @@ def testHypot(self):
# Test allowable types (those with __float__)
self.assertEqual(hypot(12.0, 5.0), 13.0)
self.assertEqual(hypot(12, 5), 13)
self.assertEqual(hypot(1, -1), math.sqrt(2))
self.assertEqual(hypot(1, FloatLike(-1.)), math.sqrt(2))
self.assertEqual(hypot(0.75, -1), 1.25)
self.assertEqual(hypot(-1, 0.75), 1.25)
self.assertEqual(hypot(0.75, FloatLike(-1.)), 1.25)
self.assertEqual(hypot(FloatLike(-1.), 0.75), 1.25)
self.assertEqual(hypot(Decimal(12), Decimal(5)), 13)
self.assertEqual(hypot(Fraction(12, 32), Fraction(5, 32)), Fraction(13, 32))
self.assertEqual(hypot(bool(1), bool(0), bool(1), bool(1)), math.sqrt(3))
self.assertEqual(hypot(True, False, True, True, True), 2.0)

# Test corner cases
self.assertEqual(hypot(0.0, 0.0), 0.0) # Max input is zero
Expand Down Expand Up @@ -969,9 +971,9 @@ def testDist(self):
self.assertEqual(dist((D(14), D(1)), (D(2), D(-4))), D(13))
self.assertEqual(dist((F(14, 32), F(1, 32)), (F(2, 32), F(-4, 32))),
F(13, 32))
self.assertEqual(dist((True, True, False, True, False),
(True, False, True, True, False)),
sqrt(2.0))
self.assertEqual(dist((True, True, False, False, True, True),
(True, False, True, False, False, False)),
2.0)

# Test corner cases
self.assertEqual(dist((13.25, 12.5, -3.25),
Expand Down
Loading