Skip to content

[debug] Testing changes to Deferred LOAD_GLOBAL on Windows10 buildbot #124082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

[debug] Testing changes to Deferred LOAD_GLOBAL on Windows10 buildbot #124082

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
831d5fa
Revert "gh-121459: Deferred LOAD_GLOBAL (GH-123128)"
colesbury Sep 13, 2024
14cc3d3
Test change to bytecodes.c
colesbury Sep 14, 2024
7ca5366
Add code side-by-side
colesbury Sep 14, 2024
f6a8e41
Use deferred rc in bytecodes.c
colesbury Sep 14, 2024
bc81617
Use _PyEval_LoadGlobal in _PyEval_LoadGlobalStackRef
colesbury Sep 14, 2024
4491343
Use _PyDict_LoadGlobal
colesbury Sep 14, 2024
67bc9cc
Use _PyDict_LoadGlobal in _PyDict_LoadGlobalStackRef
colesbury Sep 14, 2024
6c61fc8
Always initialize res in _PyDict_LoadGlobalStackRef
colesbury Sep 14, 2024
4321cdc
Add missing return
colesbury Sep 14, 2024
17d16e1
Try using _Py_dict_lookup_threadsafe
colesbury Sep 14, 2024
64ed3e8
Use _Py_dict_lookup_threadsafe_stackref for builtins
colesbury Sep 14, 2024
ced1ff3
use PyStackRef_FromPyObjectSteal in _Py_dict_lookup_threadsafe_stackref
colesbury Sep 14, 2024
e8d67c8
Simplify
colesbury Sep 14, 2024
005bda7
Try using PyStackRef_FromPyObjectNew again
colesbury Sep 14, 2024
b3b14b4
Try using conditional operator again
colesbury Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1550,7 +1550,7 @@ _Py_dict_lookup_threadsafe_stackref(PyDictObject *mp, PyObject *key, Py_hash_t h
{
PyObject *val;
Py_ssize_t ix = _Py_dict_lookup(mp, key, hash, &val);
*value_addr = val == NULL ? PyStackRef_NULL : PyStackRef_FromPyObjectNew(val);
*value_addr = val == NULL ? PyStackRef_NULL : PyStackRef_FromPyObjectNew(val);
return ix;
}

Expand Down Expand Up @@ -2484,6 +2484,7 @@ _PyDict_LoadGlobalStackRef(PyDictObject *globals, PyDictObject *builtins, PyObje
ix = _Py_dict_lookup_threadsafe_stackref(globals, key, hash, res);
if (ix == DKIX_ERROR) {
*res = PyStackRef_NULL;
return;
}
if (ix != DKIX_EMPTY && !PyStackRef_IsNull(*res)) {
return;
Expand Down
Loading