Skip to content

Conversation

rruuaanng
Copy link
Contributor

I changed têšt to test in test_xmlrpc.py, because I thought it wasn't an ASCII character.

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Sep 15, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 15, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Wulian233
Copy link
Contributor

Wulian233 commented Sep 15, 2024

I think it was intentional (func name is test_nonascii_methodname encoding='ascii')

https://github.com/python/cpython/blob/main/Lib/test/test_xmlrpc.py#L848-L849

def test_nonascii_methodname(self): 
      try: 
          p = xmlrpclib.ServerProxy(URL, encoding='ascii')
          self.assertEqual(p.têšt(42), 42)

BTW, most changes need a issue number

@rruuaanng
Copy link
Contributor Author

rruuaanng commented Sep 15, 2024

I think it was intentional (func name is test_nonascii_methodname encoding='ascii')

https://github.com/python/cpython/blob/main/Lib/test/test_xmlrpc.py#L848-L849

def test_nonascii_methodname(self): 
      try: 
          p = xmlrpclib.ServerProxy(URL, encoding='ascii')
          self.assertEqual(p.têšt(42), 42)

BTW, most changes need a issue number

Not all PR need to be numbered, but I didn't notice the method name, it seems you are right.

@rruuaanng rruuaanng closed this Sep 15, 2024
@rruuaanng rruuaanng deleted the dev7 branch September 20, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants