Skip to content

Conversation

rghe
Copy link
Contributor

@rghe rghe commented Sep 22, 2024

@ZeroIntensity
Copy link
Member

This is a user-facing bug, we need a news entry.

@rghe
Copy link
Contributor Author

rghe commented Sep 23, 2024

News added, thank you.

@ZeroIntensity
Copy link
Member

I've added the sqlite topic label to get some people who are more familiar with the module on this -- the ASan failures have me a little worried.

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I don't know what happened with ASan. LGTM.

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Sep 24, 2024

Thanks, but I'd prefer if we fixed the root cause. Landing this in main won't help anybody anyway, and backporting to 3.13 is probably out of the question now that we're so close to the final release. (It would have to be 3.13.1 earliest.)

@rghe
Copy link
Contributor Author

rghe commented Sep 24, 2024

Yes, I understand, but IMHO, even with #118172 fixed, the sqlite module can't share cursors between threads without extensive changes, so returning 3 is still a bug.
Fixing #118172 should allow connection sharing, however, so perhaps a better fix would be returning 2 ?
BTW, I'd like to help, if you think it could be useful.

@python-cla-bot
Copy link

The following commit authors need to sign the Contributor License Agreement:

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants