Skip to content

gh-124294: str.format() raises misleading error when using negative indices #124372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

gh-124294: str.format() raises misleading error when using negative indices #124372

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2f24f22
Add error handling for invalid sequence index
makukha Sep 23, 2024
470fd35
Merge remote-tracking branch 'upstream/main' into str-format-negative
makukha Sep 23, 2024
201e4b1
Add tests
makukha Sep 24, 2024
0d67891
Add news entry
makukha Sep 24, 2024
7ec5eb8
Fix errors and update error message
makukha Sep 24, 2024
080802a
Updatee tests
makukha Sep 24, 2024
8eeca72
PEP7-ize
makukha Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Objects/stringlib/unicode_format.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,8 +462,17 @@ get_field_object(SubString *input, PyObject *args, PyObject *kwargs,
tmp = getattr(obj, &name);
else
/* getitem lookup "[]" */
if (index == -1)
if (index == -1) {
if (PySequence_Check(obj)) {
PyObject *str = SubString_new_object(&name);
/* TypeError is for backward compatibility */
PyErr_Format(PyExc_TypeError,
"Sequence index must consist of digits, \"%S\" is not allowed",
str);
goto error;
}
tmp = getitem_str(obj, &name);
}
else
if (PySequence_Check(obj))
tmp = getitem_sequence(obj, index);
Expand Down
Loading