Skip to content

gh-124385: Document and soft-deprecate PyLong_AS_LONG #124386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2024
Merged

gh-124385: Document and soft-deprecate PyLong_AS_LONG #124386

merged 3 commits into from
Sep 27, 2024

Conversation

@encukou
Copy link
Member

@encukou encukou commented Sep 23, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 23, 2024
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Sep 23, 2024
serhiy-storchaka
serhiy-storchaka reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a deprecated or deprecated-removed directive. It needs also a NEWS entry and a What's New entry.

@encukou encukou added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 24, 2024
@encukou
Copy link
Member Author

encukou commented Sep 24, 2024

The function itself is not new, and it was always discouraged.
IMO, is PR correctly describes PyLong_AS_LONG in Python 3.0-3.13. Only the docs are new, and we can backport them into all branches that accept doc fixes.

@serhiy-storchaka
Copy link
Member

The deprecation is new.

@encukou
Copy link
Member Author

encukou commented Sep 24, 2024

Yeah, but it's a soft deprecation. Nothing depends on when we officially said you shouldn't use it.

vstinner
vstinner reviewed Sep 24, 2024
View reviewed changes
@vstinner
Copy link
Member

I don't think that this change should be backported. Or if you want to backport it, it should be without the soft deprecation.

encukou
encukou commented Sep 25, 2024
View reviewed changes
vstinner
vstinner approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

encukou
encukou commented Sep 27, 2024
View reviewed changes
@encukou encukou enabled auto-merge (squash) September 27, 2024 23:21
@encukou encukou merged commit 425587a into python:main Sep 27, 2024
23 checks passed
@miss-islington-app
Copy link

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2024
@encukou @miss-islington
pythongh-124385: Document and soft-deprecate PyLong_AS_LONG (pythonGH…
fabb02c 
…-124386)

(cherry picked from commit 425587a)

Co-authored-by: Petr Viktorin <[email protected]>
@miss-islington-app
Copy link

Sorry, @encukou, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 425587a110eb214a097c634d4b6d944ac478923e 3.12

@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2024

GH-124719 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 27, 2024
Yhg1s pushed a commit that referenced this pull request Sep 30, 2024
@miss-islington @encukou
[3.13] gh-124385: Document and soft-deprecate PyLong_AS_LONG (GH-124386…
e8980b1 
…) (#124719)

gh-124385: Document and soft-deprecate PyLong_AS_LONG (GH-124386)
(cherry picked from commit 425587a)

Co-authored-by: Petr Viktorin <[email protected]>
@encukou encukou deleted the PyLong_AS_LONG branch October 1, 2024 14:02
hugovk pushed a commit to hugovk/cpython that referenced this pull request Feb 25, 2025
@encukou @hugovk
[3.12] pythongh-124385: Document and soft-deprecate PyLong_AS_LONG (p…
986e5aa 
…ythonGH-124386)

(cherry picked from commit 425587a)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 25, 2025

GH-130549 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 25, 2025
hugovk added a commit that referenced this pull request Mar 17, 2025
@hugovk @encukou
[3.12] gh-124385: Document and soft-deprecate PyLong_AS_LONG (GH-124386…
4c1d529 
…) (#130549)

(cherry picked from commit 425587a)

Co-authored-by: Petr Viktorin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@vstinner vstinner vstinner approved these changes

Assignees

@encukou encukou

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@encukou @serhiy-storchaka @vstinner