gh-124351: Optimize Endianness Handling in ctypes Module #124355 #124407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The global variable _OTHER_ENDIAN passed as an argument to _other_endian function. Redundant type checks in_other_types function recursion handled. In setattr method, used list comprehension to avoid unnecessary creation of lists.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
skirpichev
reviewed
Sep 24, 2024
There was a problem hiding this comment.
This pr has mostly a lot of formatting changes. Usually such changes alone - will be rejected.
And there is another pr to address same issue: #124355 Lets close this one in favor of another pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global variable _OTHER_ENDIAN passed as an argument to _other_endian function. Redundant type checks in_other_types function recursion handled. In setattr method, used list comprehension to avoid unnecessary creation of lists.