Doc: Convert the download page to reST #124614
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
added
docs
AA-Turner
commented
Sep 26, 2024
Comment on lines
72
to
+77
| rst_epilog = f""" | ||
| .. |archives_version| replace:: {version if 'daily' in tags else release} | ||
| .. |python_version_literal| replace:: ``Python {version}`` | ||
| .. |python_x_dot_y_literal| replace:: ``python{version}`` | ||
| .. |usr_local_bin_python_x_dot_y_literal| replace:: ``/usr/local/bin/python{version}`` | ||
| """ | ||
| """ # noqa: F821 |
There was a problem hiding this comment.
|
I'm not too keen on this, it's replacing an HTML template with RST but at the cost of introducing a new Sphinx extension to maintain. And the HTML isn't too complex. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening for comment. Having the download page be more normal is probably for the best, but it does require a Sphinx extension, rather than "just" Jinja templating.
A
📚 Documentation preview 📚: https://cpython-previews--124614.org.readthedocs.build/