Skip to content

Conversation

@rruuaanng
Copy link
Contributor

No description provided.

@rruuaanng rruuaanng requested a review from a team as a code owner September 27, 2024 14:10
@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@rruuaanng
Copy link
Contributor Author

cc @skirpichev

@skirpichev
Copy link
Contributor

See https://devguide.python.org/getting-started/pull-request-lifecycle/#making-good-prs

"Pull requests with only code formatting changes are usually rejected." (c)

@rruuaanng
Copy link
Contributor Author

See https://devguide.python.org/getting-started/pull-request-lifecycle/#making-good-prs

"Pull requests with only code formatting changes are usually rejected." (c)

This commit only fixes the indentation, I don't think any other extra changes are needed.

@rruuaanng
Copy link
Contributor Author

Since the only problem is the weird indentation, fixing this alone is enough to clean up the code.

@zooba
Copy link
Member

zooba commented Sep 27, 2024

The point @skirpichev is making is that we don't accept cosmetic PRs. When some functionality is causing us to change code in that area, we'll fix up the formatting, but we don't want people spending time going through tweaking cosmetics all the time.

@zooba zooba closed this Sep 27, 2024
@rruuaanng rruuaanng deleted the dev6 branch September 27, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants