gh-124748: Fix handling kwargs in WeakKeyDictionary.update()

[ri-gilfanov]

Removed 2 lines for updating WeakKeyDictionary objects by keyword arguments. This did not work correctly because weak references to str objects are not supported.

Added clear exception that keyword arguments are not supported in update() method.

• Issue: Non-working code in update() method of weakref.WeakKeyDictionary #124748

[ghost]

All commit authors signed the Contributor License Agreement.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[sobolevn]

Please, add:

• a NEWS entry
• a test case for this

Congrats on your first PR to CPython 👍

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[ri-gilfanov]

@sobolevn, thank you. Now all linters and checkers are green

[sobolevn]

My take on better wording

[ri-gilfanov]

WARNING: py:meth reference target not found: weakref.WeakKeyDictionary.update [ref.meth]

@sobolevn and @tomasr8, I think the message in the Docs workflow is being output because the weakref module doesn't document the standard dictionary methods. Should I remove the reference to the undocumented method?

[sobolevn]

Other than my suggestion, this looks good to me.

But, I am not an expert in weakref. So, I would like to get a second review.

@rhettinger or @ambv, would you be interested? Based on https://github.com/python/cpython/commits/main/Lib/weakref.py

[ri-gilfanov]

@sobolevn, also when I fixed the message mismatch in the exception and test, I apparently undid 2 edits in it. I think I should put them back and do a squash of commits. There are not so many changes to keep a detailed history of them

[tomasr8]

I think I should put them back and do a squash of commits. There are not so many changes to keep a detailed history of them

Normally it's best to avoid squashing/force pushing even for small changes since it rewrites the history and can make reviewing the PR more difficult 🙂