Skip to content

gh-122864: Fix a test_funcattrs.test___builtins__ when executing directly #124845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2024
Merged

gh-122864: Fix a test_funcattrs.test___builtins__ when executing directly #124845

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad7f326
GH-122864: Fix a unit test which was failing when the test module was
mbyrnepr2 Oct 1, 2024
6606c32
Condense the comment by omitting the extra links.
mbyrnepr2 Oct 1, 2024
302b763
Update Lib/test/test_funcattrs.py
mbyrnepr2 Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions Lib/test/test_funcattrs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,23 @@ def test___globals__(self):
(AttributeError, TypeError))

def test___builtins__(self):
self.assertIs(self.b.__builtins__, __builtins__)
if __name__ == "__main__":
# `func.__builtins__` is `builtins.__dict__`.
# See:https://bugs.python.org/issue42990

# When this test is run by executing the current module,
# `__builtins__` is the built-in module `builtins`.

# When this test is run from another module, `__builtins__` is
# `builtins.__dict__`
# See: https://docs.python.org/3/reference/executionmodel.html#builtins-and-restricted-execution

import builtins
builtins_dict = builtins.__dict__
else:
builtins_dict = __builtins__

self.assertIs(self.b.__builtins__, builtins_dict)
self.cannot_set_attr(self.b, '__builtins__', 2,
(AttributeError, TypeError))

Expand All @@ -108,7 +124,7 @@ def func(s): return len(s)
ns = {}
func2 = type(func)(func.__code__, ns)
self.assertIs(func2.__globals__, ns)
self.assertIs(func2.__builtins__, __builtins__)
self.assertIs(func2.__builtins__, builtins_dict)

# Make sure that the function actually works.
self.assertEqual(func2("abc"), 3)
Expand Down
Loading