[3.13] gh-122864: Fix a test_funcattrs.test___builtins__ when executing directly (GH-124845)
#124884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uting directly (pythonGH-124845) Previously when executing ``test_functattrs.test___builtins__`` directly, it failed because the fact, that ``__builtins__`` is refers to the built-in module ``builtins`` while it's expects a ``__builtins__.__dict__``. But when this test is being run from another module, then ``__builtins__`` is refers to ``builtins.__dict__``. Now this part of the behaviour is covered. --------- (cherry picked from commit 8fbf10d) Co-authored-by: Mark Byrne <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
Eclips4
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when executing
test_functattrs.test___builtins__directly, it failed because the fact, that__builtins__is refers to the built-in modulebuiltinswhile it's expects a__builtins__.__dict__. But when this test is being run from another module, then__builtins__is refers tobuiltins.__dict__. Now this part of the behaviour is covered.(cherry picked from commit 8fbf10d)
Co-authored-by: Mark Byrne [email protected]
Co-authored-by: Victor Stinner [email protected]
Lib/test/test_funcattrs.pydirectly fails #122864