Strip absolute --libdir paths from configure args in test_freeze #124916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the motivation here? Is there an issue where this is discussed? |
|
The motivation here is that this test fails in Debian's package build, because we set |
stefanor
force-pushed
the
test-freeze-destdir
branch
from
f696602 to
fa75fdd
Compare
stefanor
force-pushed
the
test-freeze-destdir
branch
from
fa75fdd to
6720176
Compare
stefanor
force-pushed
the
test-freeze-destdir
branch
from
6720176 to
cf4b4ab
Compare
We are trying to install into a prefix, any absolute path would not necessarily be writeable. e.g. if Python is configured with --libdir=/usr/lib/$(MULTIARCH)/ during a Debian build.
stefanor
force-pushed
the
test-freeze-destdir
branch
from
cf4b4ab to
d988ef0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to install into a prefix, any absolute path would not necessarily be writeable at build/test time. e.g. if Python is configured with
--libdir=/usr/lib/$(MULTIARCH)/during a Debian build.