Skip to content

gh-123961: convert curses.window static type into a heap type #124934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 4, 2024
Merged

gh-123961: convert curses.window static type into a heap type #124934

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b0c5b64
Make `PyCursesWindow_Type` a heap type.
picnixz Oct 3, 2024
cd2c1c5
update changelog
picnixz Oct 3, 2024
e46c279
remove useless casts
picnixz Oct 3, 2024
7fcd779
Keep same formulation for blurb
picnixz Oct 3, 2024
ccaf575
Remove What's New entry
picnixz Oct 3, 2024
beecc6b
use Py_TPFLAGS_HAVE_GC
picnixz Oct 3, 2024
45183e7
why am I using GH Web UI
picnixz Oct 3, 2024
9c787bc
...
picnixz Oct 3, 2024
f5485e9
Update 2024-10-03-14-06-08.gh-issue-123961.uwJQTY.rst
picnixz Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Modules/_cursesmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,8 @@
}
}

PyCursesWindowObject *wo = PyObject_New(PyCursesWindowObject, state->window_type);
PyCursesWindowObject *wo = PyObject_GC_New(PyCursesWindowObject,
state->window_type);
if (wo == NULL) {
return NULL;
}
Expand All @@ -780,13 +781,15 @@
PyErr_NoMemory();
return NULL;
}
PyObject_GC_Track((PyObject *)wo);
return (PyObject *)wo;
}

static void
PyCursesWindow_dealloc(PyObject *self)
{
PyTypeObject *window_type = Py_TYPE(self);
PyObject_GC_Untrack(self);

Check failure on line 792 in Modules/_cursesmodule.c

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-22.04) 

implicit declaration of function ‘PyObject_GC_Untrack’; did you mean ‘PyObject_GC_UnTrack’? [-Werror=implicit-function-declaration]

Check failure on line 792 in Modules/_cursesmodule.c

View workflow job for this annotation

GitHub Actions / Address sanitizer 

implicit declaration of function ‘PyObject_GC_Untrack’; did you mean ‘PyObject_GC_UnTrack’? [-Werror=implicit-function-declaration]

Check failure on line 792 in Modules/_cursesmodule.c

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

implicit declaration of function ‘PyObject_GC_Untrack’; did you mean ‘PyObject_GC_UnTrack’? [-Werror=implicit-function-declaration]
PyCursesWindowObject *wo = (PyCursesWindowObject *)self;
if (wo->win != stdscr && wo->win != NULL) {
// silently ignore errors in delwin(3)
Expand Down Expand Up @@ -2694,7 +2697,8 @@
.flags = Py_TPFLAGS_DEFAULT
| Py_TPFLAGS_DISALLOW_INSTANTIATION
| Py_TPFLAGS_IMMUTABLETYPE
| Py_TPFLAGS_HEAPTYPE,
| Py_TPFLAGS_HEAPTYPE
| Py_TPFLAGS_HAVE_GC,
.slots = PyCursesWindow_Type_slots
};

Expand Down
Loading