Skip to content

Simplify partial() rough equivalent code #124941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Simplify partial() rough equivalent code #124941

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1605e74
Simplify partial() rough equivalent code
rhettinger Oct 3, 2024
0b065f4
Update Doc/library/functools.rst
rhettinger Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Doc/library/functools.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,8 +347,7 @@ The :mod:`functools` module defines the following functions:

def partial(func, /, *args, **keywords):
def newfunc(*more_args, **more_keywords):
keywords_union = {**keywords, **more_keywords}
return func(*args, *more_args, **keywords_union)
return func(*args, *more_args, **keywords | more_keywords)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks confusing to me, because ** is closer to keywords than |. According to the PEP 8 style it looks like (**keywords) | more_keywords rather than **(keywords | more_keywords). I think it will be confusing for many readers.

To avoid confusion, you can add parentheses. Or leave the code as it is.

newfunc.func = func
newfunc.args = args
newfunc.keywords = keywords
Expand Down
Loading