Skip to content

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Oct 4, 2024

@graingert
Copy link
Contributor Author

this is only half of the work as the flag needs to be used when reuse_port=True is passed to various apis

@graingert graingert marked this pull request as ready for review October 4, 2024 10:00
@graingert graingert requested a review from picnixz October 14, 2024 23:03
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the PR for SO_ORIGINAL_DST that I just reviewed, I didn't really feel the need to document it since we don't really document every constant (and it was better to have the constant included without going through a round of documentation review).

Here, since it's FreeBSD-only I think it's nice to document it (SO_ORIGINAL_DST is exposed assuming some headers, which would probably make its docs a bit messy I think). Since there's no conditional header, I appreciate the additional documentation.

Note: I haven't thought about it but we could have actually added some .. versionadded to the SO_* entries though for SO_ORIGINAL_DST.


I'd also like @erlend-aasland's review on this one if possible.

@graingert graingert requested a review from picnixz December 4, 2024 04:24
@graingert
Copy link
Contributor Author

@picnixz can I get a merge?

@picnixz
Copy link
Member

picnixz commented Dec 5, 2024

Er... I'm not a core dev! we should ask @erlend-aasland or maybe you give me commit rights for this one

@graingert graingert requested a review from picnixz December 25, 2024 21:40
@picnixz
Copy link
Member

picnixz commented Dec 25, 2024

(I'm still not a core dev, I still can't merge this one :()

@kumaraditya303 kumaraditya303 merged commit 9ddc388 into python:main Dec 26, 2024
41 checks passed
@graingert graingert deleted the so-reuseport-lb branch December 26, 2024 15:17
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants