-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-124761: add socket.SO_REUSEPORT_LB #124961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this is only half of the work as the flag needs to be used when reuse_port=True is passed to various apis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the PR for SO_ORIGINAL_DST
that I just reviewed, I didn't really feel the need to document it since we don't really document every constant (and it was better to have the constant included without going through a round of documentation review).
Here, since it's FreeBSD-only I think it's nice to document it (SO_ORIGINAL_DST
is exposed assuming some headers, which would probably make its docs a bit messy I think). Since there's no conditional header, I appreciate the additional documentation.
Note: I haven't thought about it but we could have actually added some .. versionadded
to the SO_*
entries though for SO_ORIGINAL_DST
.
I'd also like @erlend-aasland's review on this one if possible.
Misc/NEWS.d/next/Library/2024-10-04-09-56-45.gh-issue-124761.N4pSD6.rst
Outdated
Show resolved
Hide resolved
…4pSD6.rst Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
@picnixz can I get a merge? |
Er... I'm not a core dev! we should ask @erlend-aasland |
(I'm still not a core dev, I still can't merge this one :() |
Uh oh!
There was an error while loading. Please reload this page.