gh-125084: Resolve paths in generator common code #125085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In out of tree builds, the paths can contain `../ which needs to be resolved for the relative path calculation to work.
zware
approved these changes
Oct 8, 2024
efimov-mikhail
pushed a commit
to efimov-mikhail/cpython
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In out of tree builds, the paths can contain
../which needs to be resolved for the relative path calculation to work.Tested by running
make regen-allwhich in my dev setup (see: #125084 for layout) used to generate multiple path changes, now generates identical paths to the committed files.Can this get the no-news label? (Minor internal dev tooling change)
regen-allgenerates different paths #125084