Skip to content

gh-125118: don't copy arbitrary values to _Bool in the struct module #125169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 10, 2024
Merged

gh-125118: don't copy arbitrary values to _Bool in the struct module #125169

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
656ba8e
gh-125118: don't copy arbitrary values to _Bool in the struct module
skirpichev Oct 8, 2024
ee99e65
+ adapt for sizeof(_Bool) > 1
skirpichev Oct 9, 2024
f279538
+1
skirpichev Oct 9, 2024
53dfc10
sorry
skirpichev Oct 9, 2024
02976e7
Update Modules/_struct.c
skirpichev Oct 9, 2024
78291e4
Update Modules/_struct.c
skirpichev Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Modules/_struct.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,8 @@
static PyObject *
nu_bool(_structmodulestate *state, const char *p, const formatdef *f)
{
return PyBool_FromLong((*p) != 0);
const _Bool f = false;

Check failure on line 500 in Modules/_struct.c

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-22.04) 

‘f’ redeclared as different kind of symbol

Check failure on line 500 in Modules/_struct.c

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

‘f’ redeclared as different kind of symbol

Check failure on line 500 in Modules/_struct.c

View workflow job for this annotation

GitHub Actions / Address sanitizer 

‘f’ redeclared as different kind of symbol

Check failure on line 500 in Modules/_struct.c

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

redefinition of formal parameter 'f' [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

Check failure on line 500 in Modules/_struct.c

View workflow job for this annotation

GitHub Actions / Windows / build (arm64) 

redefinition of formal parameter 'f' [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

Check failure on line 500 in Modules/_struct.c

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build (arm64) 

redefinition of formal parameter 'f' [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
return PyBool_FromLong(memcmp(p, &f, sizeof(_Bool));

Check failure on line 501 in Modules/_struct.c

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-22.04) 

expected ‘)’ before ‘;’ token

Check failure on line 501 in Modules/_struct.c

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-22.04) 

expected ‘;’ before ‘}’ token

Check failure on line 501 in Modules/_struct.c

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

expected ‘)’ before ‘;’ token

Check failure on line 501 in Modules/_struct.c

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

expected ‘;’ before ‘}’ token

Check failure on line 501 in Modules/_struct.c

View workflow job for this annotation

GitHub Actions / Address sanitizer 

expected ‘)’ before ‘;’ token

Check failure on line 501 in Modules/_struct.c

View workflow job for this annotation

GitHub Actions / Address sanitizer 

expected ‘;’ before ‘}’ token

Check failure on line 501 in Modules/_struct.c

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

syntax error: missing ')' before ';' [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

Check failure on line 501 in Modules/_struct.c

View workflow job for this annotation

GitHub Actions / Windows / build (arm64) 

syntax error: missing ')' before ';' [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

Check failure on line 501 in Modules/_struct.c

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build (arm64) 

syntax error: missing ')' before ';' [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
}


Expand Down
Loading