gh-125234: Make PyInitConfig_Free(NULL) a no-op

[rruuaanng]

Modified PyInitConfig_Free, to release the memory occupied when the config argument isn't NULL.

PyInitConfig *config = NULL;
// some code
if (error_occurred) {
    goto Error;
}
config = PyInitConfig_Create();
if (config == NULL) {
    goto Error;
}
// some other code
if (error_occurred) {
    goto Error;
}
// more code
Error:
// release resources
PyInitConfig_Free(config);
// release resources

(I hope my understanding is correct).

• Issue: Make PyInitConfig_Free(NULL) a no-op #125234

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[ZeroIntensity]

LGTM

[ZeroIntensity]

This implementation looks fine, but the point of the original issue was to simplify things. Should that be done with this PR as well? (My approval was for the implementation, but Serhiy probably wants to deal with the use of it internally.)

[serhiy-storchaka]

Since this is a public C API change, it should be documented. Add a versionchanged directive and the What's New entry.

I am going also to get an approve of the C API Workgroup.

[ZeroIntensity]

This is already in "What's New" under PEP 741, I think.

[serhiy-storchaka]

Ah, it is new in 3.14. Then nothing of this is needed.

[ZeroIntensity]

Yeah. In fact, do we even need a NEWS entry for changes to unreleased features?

[serhiy-storchaka]

A NEWS entry is not needed.

[rruuaanng]

A NEWS entry is not needed

Maybe I can remove it.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[rruuaanng]

Maybe, I have made the corresponding changes (I hope).

[ZeroIntensity]

You didn't trigger the bot. I think saying I didn't expect the Spanish Inquisition should work too 😉

[rruuaanng]

Oh, This is really interesting! Hope this works🙂

[ZeroIntensity]

(You have to say it, the bot ignores comments from people other than the author.)

[rruuaanng]

I didn't expect the Spanish Inquisition

[bedevere-app]

Nobody expects the Spanish Inquisition!

@erlend-aasland, @kumaraditya303: please review the changes made to this pull request.

[erlend-aasland]

@rruuaanng: every time you make a comment on an issue or a PR, all subscribed parties receives a notification, or even an email. Please be respectful of others time and don't use GitHub as a forum. We have Discourse for that functionality.

[erlend-aasland]

Please also update the docs. Look to PyMem_Free and PyMem_RawFree for inspiration.

[bedevere-app]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[ZeroIntensity]

every time you make a comment on an issue or a PR, all subscribed parties receives a notification, or even an email. Please be respectful of others time and don't use GitHub as a forum.

Yeah, I was a little guilty of this too in this case, sorry :(

In general, what's the procedure for walking someone through the PR process if they're having difficulties?

[erlend-aasland]

Yeah, I was a little guilty of this too in this case, sorry :(

In general, what's the procedure for walking someone through the PR process if they're having difficulties?

No worries, you're both fine. If I notice such a pattern on a PR, I explicitly make a remark and remind the participants of this effect. Using reactions, like thumbs-up, is often sufficient. Also, thinking twice about how often we demand the attention of others may be helpful.