-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-125115: Pass unknown pdb command line args to script instead of fail #125424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f17462c
Pass unknown pdb command line args to script instead of fail
gaogaotiantian 8e8bbd5
📜🤖 Added by blurb_it.
blurb-it[bot] 1f40040
Update 2024-10-14-02-07-44.gh-issue-125115.IOf3ON.rst
gaogaotiantian 160bab6
Make arguments starting with - work with modules as well
gaogaotiantian 36dcdd0
Update comments
gaogaotiantian aac3cf6
Use takewhile for arguments
gaogaotiantian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Library/2024-10-14-02-07-44.gh-issue-125115.IOf3ON.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Fixed a bug in :mod:`pdb` where arguments starting with ``-`` can't be passed to the debugged script. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the logic here? Why are we breaking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A pdb CLI usage could be
python -m pdb script.py --bar
orpython -m pdb --bar script.py
.The unknown args would be
['script.py', '--bar']
and[--bar', 'script.py']
respectively. Notice that in the first case, the user is trying to pass--bar
toscript.py
, but in the latter, they try to pass--bar
topdb
. This logic is to differentiate this. As long as we got something that does not start with-
, we consider that as the script.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing something here, for the module case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And a test for this case..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out dealing with modules is not super trivial. I added some comments in the parsing code and hopefully that's helpful. We can "change the rule" and require users to use
--
to resolve all ambiguities, but I think it would be a better experience if we can be a bit smarter.An existing test already covers the case where
--spam -m module
should fail, I added a new test for-m calendar --type text
which works after the change.