Skip to content

Conversation

@nineteendo
Copy link
Contributor

@nineteendo nineteendo commented Oct 14, 2024

Commands ran:

$ make reindent
$ rm **/*.bak

@gvanrossum
Copy link
Member

I would like to argue on principle against this PR. We (used to?) have a guideline stating that we don't touch files for changes of this nature (also typos and similar) unless we're touching the affected code for other reasons.

Despite the claims I expect along the lines of "you can fix this with some git blame option(s)", I am unhappy when reviewing the history of some code to find irrelevant indent fixings in the history -- it disrupts the research, at the very least (and those options may not be available in all UIs for viewing git blame data). My opinion is that this particular PR adds zero value to the code base, while causing noise in the history, so I am against it.

In order to cut the discussion short, I'm just going to close the PR.

@gvanrossum gvanrossum closed this Oct 14, 2024
@nineteendo nineteendo deleted the reindent branch October 15, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants